-
Notifications
You must be signed in to change notification settings - Fork 15.3k
fix: correct JWT secret name to match deployment environment #52268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Hello, it could also be: {{- define "jwt_secret" -}}
{{- default (printf "%s-jwt_secret" (include "airflow.fullname" .)) .Values.jwtSecretName }}
{{- end }} As defined for webserver_secret_key_secret: |
That works too, but my main intention is to reuse the same variable |
@junminahn can you also fix the failing test, as the name has been fixed now? Thanks. |
I've updated the test file as needed. Could you please approve the pending workflows? |
@jedcunningham Thanks for approving the workflows; all checks are passing now. Would you mind merging this PR? Appreciate it! |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @junminahn! Congrats on your first commit 🎉 |
This PR fixes a Kubernetes deployment error (
CreateContainerConfigError
) caused by a mismatch in the JWT secret name.The issue stems from inconsistent prefixes used when referencing the secret:
jwt_secret
variable derived from.Release.Name
.airflow.fullname
variable.This mismatch led to the deployment failing to locate the expected secret.
To resolve this, the secret name has been updated to also use the
jwt_secret
variable, ensuring consistency between the secret's name and how it's referenced in the deployment.References