Skip to content

Remove pytestmark from Pagerduty test files #52146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

choo121600
Copy link
Contributor

@choo121600 choo121600 commented Jun 24, 2025

Part of #52020
clean

Some tests did not require actual database interaction, so they were simplified (maintaining identical test coverage):

  • Removed pytestmark = pytest.mark.db_test
  • Replaced dag_maker fixture with simple DAG("test_notifier") objects
  • Removed unused EmptyOperator imports and task creation

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk potiuk merged commit ad19251 into apache:main Jun 24, 2025
65 checks passed
@choo121600 choo121600 deleted the remove-db-test/pagerduty branch June 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants