Remove pytestmark from Pagerduty test files (#52146)

choo121600 · web-flow · commit ad19251f74b6 · 2025-06-24T12:17:35.000+02:00
* Remove pytestmark from Pagerduty test files

* Add PagerDuty provider to pre-commit

* fix: airflow.sdk error
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -623,6 +623,7 @@ repos:
             ^providers/openai/.*\.py$|
             ^providers/openfaas/.*\.py$|
             ^providers/oracle/.*\.py$|
+            ^providers/pagerduty/.*\.py$|
             ^providers/pgvector/.*\.py$|
             ^providers/pinecone/.*\.py$|
             ^providers/postgres/.*\.py$|
diff --git a/providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty.py b/providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty.py
@@ -22,9 +22,6 @@
 from airflow.models import Connection
 from airflow.providers.pagerduty.hooks.pagerduty import PagerdutyHook
 
-pytestmark = pytest.mark.db_test
-
-
 DEFAULT_CONN_ID = "pagerduty_default"
 
 
diff --git a/providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty_events.py b/providers/pagerduty/tests/unit/pagerduty/hooks/test_pagerduty_events.py
@@ -22,8 +22,6 @@
 from airflow.models import Connection
 from airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook
 
-pytestmark = pytest.mark.db_test
-
 DEFAULT_CONN_ID = "pagerduty_events_default"
 
 
diff --git a/providers/pagerduty/tests/unit/pagerduty/notifications/test_pagerduty.py b/providers/pagerduty/tests/unit/pagerduty/notifications/test_pagerduty.py
@@ -19,26 +19,20 @@
 
 from unittest import mock
 
-import pytest
-
+from airflow import DAG
 from airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook
 from airflow.providers.pagerduty.notifications.pagerduty import (
     PagerdutyNotifier,
     send_pagerduty_notification,
 )
-from airflow.providers.standard.operators.empty import EmptyOperator
-
-pytestmark = pytest.mark.db_test
-
 
 PAGERDUTY_API_DEFAULT_CONN_ID = PagerdutyEventsHook.default_conn_name
 
 
 class TestPagerdutyNotifier:
     @mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
-    def test_notifier(self, mock_pagerduty_event_hook, dag_maker):
-        with dag_maker("test_notifier") as dag:
-            EmptyOperator(task_id="task1")
+    def test_notifier(self, mock_pagerduty_event_hook):
+        dag = DAG("test_notifier")
         notifier = send_pagerduty_notification(summary="DISK at 99%", severity="critical", action="trigger")
         notifier({"dag": dag})
         mock_pagerduty_event_hook.return_value.send_event.assert_called_once_with(
@@ -56,9 +50,8 @@ def test_notifier(self, mock_pagerduty_event_hook, dag_maker):
         )
 
     @mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
-    def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook, dag_maker):
-        with dag_maker("test_notifier") as dag:
-            EmptyOperator(task_id="task1")
+    def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook):
+        dag = DAG("test_notifier")
         notifier = PagerdutyNotifier(summary="DISK at 99%", severity="critical", action="trigger")
         notifier({"dag": dag})
         mock_pagerduty_event_hook.return_value.send_event.assert_called_once_with(
@@ -76,9 +69,8 @@ def test_notifier_with_notifier_class(self, mock_pagerduty_event_hook, dag_maker
         )
 
     @mock.patch("airflow.providers.pagerduty.notifications.pagerduty.PagerdutyEventsHook")
-    def test_notifier_templated(self, mock_pagerduty_event_hook, dag_maker):
-        with dag_maker("test_notifier") as dag:
-            EmptyOperator(task_id="task1")
+    def test_notifier_templated(self, mock_pagerduty_event_hook):
+        dag = DAG("test_notifier")
 
         notifier = PagerdutyNotifier(
             summary="DISK at 99% {{dag.dag_id}}",
