Skip to content

Add a button to collapse/expand the information panel #51946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025

Conversation

Jasperora
Copy link
Contributor

Add a button to collapse/expand the information panel for better visualizing DAG

Related issue: #51907

Why

The right information panel takes much space, leading to smaller place for showing DAG graph.

How

Add a button to collapse/expand the right information panel.

Demo

demo.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 20, 2025
Copy link
Contributor

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Left 1 nit.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thanks for the PR, nothing much to add beside @guan404ming comments.

Copy link
Contributor

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for UI and translation changes. Thanks for resolving the comments!

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These translation makes a bit more sense to me. 🤔

cc @guan404ming @RoyLee1224 @jason810496

@Jasperora
Copy link
Contributor Author

Hi @Lee-W , thanks for the suggestions. These translations also make more sense to me. I modified it in the commit change translations for zh-TW.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good me from the translation perspective

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

As a followup PR we could show the collapseDetailsPanel and showDetailsPanel as a tooltip when hovering the button.

@pierrejeambrun pierrejeambrun merged commit e1d9be4 into apache:main Jun 24, 2025
51 checks passed
@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.0 milestone Jun 24, 2025
@Jasperora
Copy link
Contributor Author

Sure! I can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants