-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Add a button to collapse/expand the information panel #51946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Left 1 nit.
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Thanks for the PR, nothing much to add beside @guan404ming comments.
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for UI and translation changes. Thanks for resolving the comments!
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These translation makes a bit more sense to me. 🤔
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json
Outdated
Show resolved
Hide resolved
Hi @Lee-W , thanks for the suggestions. These translations also make more sense to me. I modified it in the commit change translations for zh-TW. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good me from the translation perspective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks.
As a followup PR we could show the collapseDetailsPanel
and showDetailsPanel
as a tooltip when hovering the button.
Sure! I can work on it. |
Add a button to collapse/expand the information panel for better visualizing DAG
Related issue: #51907
Why
The right information panel takes much space, leading to smaller place for showing DAG graph.
How
Add a button to collapse/expand the right information panel.
Demo
demo.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.