Skip to content

Remove sqlalchemy-spanner exclusion after it's been yanked. #51433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 5, 2025

The broken sqlalchemy-spanner 1.12.0 has been yanked:

googleapis/python-spanner-sqlalchemy#682 (comment)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk requested review from ashb and gopidesupavan as code owners June 5, 2025 11:23
@boring-cyborg boring-cyborg bot added area:dev-tools area:providers provider:google Google (including GCP) related issues labels Jun 5, 2025
@potiuk
Copy link
Member Author

potiuk commented Jun 5, 2025

Follow up after #51393

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment which I will let you handle as per your thinking, looks good otherwise

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the doc when I added this constraint, we should revert that as well

@potiuk potiuk added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label Jun 5, 2025
@potiuk potiuk force-pushed the remove-sqlalchemy-spanner-exclusion branch from e1e08c4 to bfd8345 Compare June 5, 2025 12:22
@potiuk potiuk force-pushed the remove-sqlalchemy-spanner-exclusion branch from bfd8345 to 40c1259 Compare June 5, 2025 12:24
@potiuk
Copy link
Member Author

potiuk commented Jun 5, 2025

A comment which I will let you handle as per your thinking, looks good otherwise

That is automatically updated at release time, but yeah - I removed it too.

@potiuk potiuk merged commit ebde18e into apache:main Jun 5, 2025
94 of 96 checks passed
@potiuk potiuk deleted the remove-sqlalchemy-spanner-exclusion branch June 5, 2025 14:36
Copy link

github-actions bot commented Jun 5, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker ebde18e v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Jun 5, 2025
…d. (apache#51433)

The broken sqlalchemy-spanner 1.12.0 has been yanked:
(cherry picked from commit ebde18e)

Co-authored-by: Jarek Potiuk <[email protected]>
https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
potiuk added a commit to potiuk/airflow that referenced this pull request Jun 5, 2025
…d. (apache#51433)

The broken sqlalchemy-spanner 1.12.0 has been yanked:
(cherry picked from commit ebde18e)

Co-authored-by: Jarek Potiuk <[email protected]>
https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
potiuk added a commit that referenced this pull request Jun 5, 2025
…d. (#51433) (#51449)

The broken sqlalchemy-spanner 1.12.0 has been yanked:
(cherry picked from commit ebde18e)


https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
kaxil pushed a commit that referenced this pull request Jun 6, 2025
…d. (#51433) (#51449)

The broken sqlalchemy-spanner 1.12.0 has been yanked:
(cherry picked from commit ebde18e)


https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants