-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Remove sqlalchemy-spanner exclusion after it's been yanked. #51433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follow up after #51393 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment which I will let you handle as per your thinking, looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also updated the doc when I added this constraint, we should revert that as well
e1e08c4
to
bfd8345
Compare
The broken sqlalchemy-spanner 1.12.0 has been yanked: googleapis/python-spanner-sqlalchemy#682 (comment)
bfd8345
to
40c1259
Compare
That is automatically updated at release time, but yeah - I removed it too. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker ebde18e v3-0-test This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
…d. (apache#51433) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) Co-authored-by: Jarek Potiuk <[email protected]> https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
…d. (apache#51433) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) Co-authored-by: Jarek Potiuk <[email protected]> https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
…d. (#51433) (#51449) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
…d. (#51433) (#51449) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
…1433) The broken sqlalchemy-spanner 1.12.0 has been yanked: googleapis/python-spanner-sqlalchemy#682 (comment)
The broken sqlalchemy-spanner 1.12.0 has been yanked:
googleapis/python-spanner-sqlalchemy#682 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.