Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Google provider CHANGELOG.rst #23390

Merged
merged 1 commit into from
May 2, 2022
Merged

Cleanup Google provider CHANGELOG.rst #23390

merged 1 commit into from
May 2, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented May 1, 2022


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@eladkal eladkal requested a review from turbaszek as a code owner May 1, 2022 10:25
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 1, 2022
@eladkal
Copy link
Contributor Author

eladkal commented May 1, 2022

@potiuk I finished with deprecations for Google. There are some more deprecations but we can handle them in the next major release
Let me know if you want me to add PR numbers to each entry

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This is perfectly fine! Thanks for doing It!. We will have list of PRs in the detailed changelog that will follow the manually added one and this has been the approach we followed before.

@eladkal
Copy link
Contributor Author

eladkal commented May 1, 2022

ok so this is just styling for easier read

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit fa0cc7c into apache:main May 2, 2022
@eladkal eladkal deleted the log branch May 11, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants