Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CloudSQLProxyRunner download URLs #23299

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

jackwotherspoon
Copy link
Contributor

closes: #23292

When #22127 was merged, the CloudSQLProxyRunner started looking for a binary with an x86_64 suffix instead of amd64. This is causing the CLOUD_SQL_PROXY_DOWNLOAD_URL to point to a broken link that does not exist.

The Cloud SQL Proxy does not have any x86_64 download links for Linux machines thus replacing it to amd64 should fix this issue and allow the proper download links to be found by the CloudSQLProxyRunner.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 27, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh my bad with the original commit :(
Thanks for fixing that.

This is really unfortunate how different naming of platforms is inconsistent.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 27, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@leahecole leahecole merged commit 1f32603 into apache:main Apr 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Composer v1.18.6 and 2.0.10 incompatible with CloudSqlProxyRunner
3 participants