Change ComputeSSH to throw provider import error instead paramiko #23035
Conversation
|
It also required ssh provider Should we add it to additional extras? airflow/airflow/providers/google/provider.yaml Lines 909 to 913 in c36bcc4 |
|
Not needed. This happens automatically |
|
See - https://airflow.apache.org/docs/apache-airflow-providers-google/stable/index.html#cross-provider-package-dependencies there is an Paramiko should be added "after" importing provider - then it will be handled as "optional feature" automatically - and we do not need to change setup.py. Good comment @mik-laj ! |
|
I will add some testing harness for such imports soon :) |
214aec4
to
c916ecd
Compare
|
I fixed it differently now. Together with #23037 changing import errors should fix it as we will get just info message that SSH provider is not available so the Hook won't work. |
The paramiko import should be done after ssh provider to properly detect it as an optional Google Provider feature. Part of: apache#23033
c916ecd
to
2f65c84
Compare
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
The paramiko import should be done after ssh provider to properly
detect it as an optional Google Provider feature.
Part of: #23033
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.