Fix the gcp_gcs_delete_objects on empty list (#32383)

apache · Jul 6, 2023 · e7587b3 · e7587b3
1 parent becfb3c
commit e7587b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/airflow/providers/google/cloud/operators/gcs.py b/airflow/providers/google/cloud/operators/gcs.py
@@ -323,7 +323,7 @@ def execute(self, context: Context) -> None:
  impersonation_chain=self.impersonation_chain,
  )
 
- if self.objects:
+ if self.objects is not None:
  objects = self.objects
  else:
  objects = hook.list(bucket_name=self.bucket_name, prefix=self.prefix)

diff --git a/tests/providers/google/cloud/operators/test_gcs.py b/tests/providers/google/cloud/operators/test_gcs.py
@@ -124,6 +124,14 @@ def test_delete_objects(self, mock_hook):
  any_order=True,
  )
 
+ @mock.patch("airflow.providers.google.cloud.operators.gcs.GCSHook")
+ def test_delete_empty_list_of_objects(self, mock_hook):
+ operator = GCSDeleteObjectsOperator(task_id=TASK_ID, bucket_name=TEST_BUCKET, objects=[])
+
+ operator.execute(None)
+ mock_hook.return_value.list.assert_not_called()
+ mock_hook.return_value.delete.assert_not_called()
+
  @mock.patch("airflow.providers.google.cloud.operators.gcs.GCSHook")
  def test_delete_prefix(self, mock_hook):
  mock_hook.return_value.list.return_value = MOCK_FILES[1:4]