Skip to content

Commit

Permalink
Change log level to DEBUG when secret not found for google secret man…
Browse files Browse the repository at this point in the history
…ager (#27856)
  • Loading branch information
Łukasz Wyszomirski committed Dec 3, 2022
1 parent 144f88b commit 6b3bb3c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Expand Up @@ -75,7 +75,7 @@ def get_secret(self, secret_id: str, project_id: str, secret_version: str = "lat
value = response.payload.data.decode("UTF-8")
return value
except NotFound:
self.log.error("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)
self.log.debug("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)
return None
except PermissionDenied:
self.log.error(
Expand Down
4 changes: 2 additions & 2 deletions tests/providers/google/cloud/secrets/test_secret_manager.py
Expand Up @@ -127,7 +127,7 @@ def test_get_conn_uri_non_existent_key(self, mock_client_callable, mock_get_cred

secrets_manager_backend = CloudSecretManagerBackend(connections_prefix=CONNECTIONS_PREFIX)
secret_id = secrets_manager_backend.build_path(CONNECTIONS_PREFIX, CONN_ID, SEP)
with self.assertLogs(secrets_manager_backend.client.log, level="ERROR") as log_output:
with self.assertLogs(secrets_manager_backend.client.log, level="DEBUG") as log_output:
assert secrets_manager_backend.get_conn_uri(conn_id=CONN_ID) is None
assert secrets_manager_backend.get_connection(conn_id=CONN_ID) is None
assert re.search(
Expand Down Expand Up @@ -202,7 +202,7 @@ def test_get_variable_non_existent_key(self, mock_client_callable, mock_get_cred

secrets_manager_backend = CloudSecretManagerBackend(variables_prefix=VARIABLES_PREFIX)
secret_id = secrets_manager_backend.build_path(VARIABLES_PREFIX, VAR_KEY, SEP)
with self.assertLogs(secrets_manager_backend.client.log, level="ERROR") as log_output:
with self.assertLogs(secrets_manager_backend.client.log, level="DEBUG") as log_output:
assert secrets_manager_backend.get_variable(VAR_KEY) is None
assert re.search(
f"Google Cloud API Call Error \\(NotFound\\): Secret ID {secret_id} not found",
Expand Down

0 comments on commit 6b3bb3c

Please sign in to comment.