Fix bigquery-hook when no engine_kwargs are passed

apache · Feb 13, 2022 · 6579648 · 6579648
1 parent 91014f0
commit 6579648
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/airflow/providers/google/cloud/hooks/bigquery.py b/airflow/providers/google/cloud/hooks/bigquery.py
@@ -163,6 +163,8 @@ def get_sqlalchemy_engine(self, engine_kwargs=None):
  :param engine_kwargs: Kwargs used in :func:`~sqlalchemy.create_engine`.
  :return: the created engine.
  """
+ if engine_kwargs is None:
+ engine_kwargs = {}
  connection = self.get_connection(self.gcp_conn_id)
  if connection.extra_dejson.get("extra__google_cloud_platform__key_path"):
  credentials_path = connection.extra_dejson['extra__google_cloud_platform__key_path']

diff --git a/tests/providers/google/cloud/hooks/test_bigquery.py b/tests/providers/google/cloud/hooks/test_bigquery.py
@@ -936,7 +936,7 @@ def test_insert_job(self, mock_client, mock_query_job, nowait):
  def test_dbapi_get_uri(self):
  assert self.hook.get_uri().startswith('bigquery://')
 
- def test_dbapi_get_sqlalchemy_engine(self):
+ def test_dbapi_get_sqlalchemy_engine_failed(self):
  with pytest.raises(
  AirflowException,
  match="For now, we only support instantiating SQLAlchemy engine by"