Replace default api_version of FacebookAdsReportToGcsOperator (#18996)

apache · Oct 15, 2021 · 406b38b · 406b38b
1 parent 258451c
commit 406b38b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py b/airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py
@@ -53,7 +53,8 @@ class FacebookAdsReportToGcsOperator(BaseOperator):
  :type gcp_conn_id: str
  :param facebook_conn_id: Airflow Facebook Ads connection ID
  :type facebook_conn_id: str
- :param api_version: The version of Facebook API. Default to v6.0
+ :param api_version: The version of Facebook API. Default to None. If it is None,
+ it will use the Facebook business SDK default version.
  :type api_version: str
  :param fields: List of fields that is obtained from Facebook. Found in AdsInsights.Field class.
  https://developers.facebook.com/docs/marketing-api/insights/parameters/v6.0
@@ -95,7 +96,7 @@ def __init__(
  params: Dict[str, Any] = None,
  parameters: Dict[str, Any] = None,
  gzip: bool = False,
- api_version: str = "v6.0",
+ api_version: Optional[str] = None,
  gcp_conn_id: str = "google_cloud_default",
  facebook_conn_id: str = "facebook_default",
  impersonation_chain: Optional[Union[str, Sequence[str]]] = None,

diff --git a/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs.py b/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs.py
@@ -23,7 +23,6 @@
 GCS_CONN_ID = "google_cloud_default"
 IMPERSONATION_CHAIN = ["ACCOUNT_1", "ACCOUNT_2", "ACCOUNT_3"]
 FACEBOOK_ADS_CONN_ID = "facebook_default"
-API_VERSION = "v6.0"
 FIELDS = [
  "campaign_name",
  "campaign_id",
@@ -58,7 +57,7 @@ def test_execute(self, mock_gcs_hook, mock_ads_hook):
  impersonation_chain=IMPERSONATION_CHAIN,
  )
  op.execute({})
- mock_ads_hook.assert_called_once_with(facebook_conn_id=FACEBOOK_ADS_CONN_ID, api_version=API_VERSION)
+ mock_ads_hook.assert_called_once_with(facebook_conn_id=FACEBOOK_ADS_CONN_ID, api_version=None)
  mock_ads_hook.return_value.bulk_facebook_report.assert_called_once_with(
  params=PARAMETERS, fields=FIELDS
  )