Add missing pre-commit definition - provider-yamls (#12393)

apache · Nov 17, 2020 · 2cda2f2 · 2cda2f2
1 parent 8cee95f
commit 2cda2f2
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -451,6 +451,13 @@ repos:
  always_run: true
  entry: ./scripts/ci/pre_commit/pre_commit_check_providers_init.sh
  language: system
+ - id: provider-yamls
+ name: Validate providers.yaml files
+ pass_filenames: false
+ entry: ./scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
+ language: python
+ require_serial: true
+ additional_dependencies: ['PyYAML==5.3.1', 'jsonschema==3.2.0', 'tabulate==0.8.7']
  - id: mermaid
  name: Generate mermaid images
  entry: ./scripts/ci/pre_commit/pre_commit_mermaid.sh

diff --git a/BREEZE.rst b/BREEZE.rst
@@ -2015,11 +2015,11 @@ This is the current syntax for `./breeze <./breeze>`_:
  helm-lint incorrect-use-of-LoggingMixin insert-license isort language-matters
  lint-dockerfile lint-openapi markdownlint mermaid mixed-line-ending mypy mypy-helm
  no-providers-in-core-examples no-relative-imports pre-commit-descriptions
- provide-create-sessions providers-init-file pydevd pydocstyle pylint pylint-tests
- python-no-log-warn pyupgrade restrict-start_date rst-backticks setup-order
- setup-extra-packages shellcheck sort-in-the-wild stylelint trailing-whitespace
- update-breeze-file update-extras update-local-yml-file update-setup-cfg-file
- version-sync yamllint
+ provide-create-sessions providers-init-file provider-yamls pydevd pydocstyle pylint
+ pylint-tests python-no-log-warn pyupgrade restrict-start_date rst-backticks
+ setup-order setup-extra-packages shellcheck sort-in-the-wild stylelint
+ trailing-whitespace update-breeze-file update-extras update-local-yml-file
+ update-setup-cfg-file version-sync yamllint
 
  You can pass extra arguments including options to to the pre-commit framework as
  <EXTRA_ARGS> passed after --. For example:

diff --git a/STATIC_CODE_CHECKS.rst b/STATIC_CODE_CHECKS.rst
@@ -134,6 +134,8 @@ require Breeze Docker images to be installed locally:
 ----------------------------------- ---------------------------------------------------------------- ------------
 ``providers-init-file`` Check that provider's __init__.py file is removed
 ----------------------------------- ---------------------------------------------------------------- ------------
+``provider-yamls`` Checks that provider.yaml files have the correct content
+----------------------------------- ---------------------------------------------------------------- ------------
 ``pydevd`` Check for accidentally committed pydevd statements.
 ----------------------------------- ---------------------------------------------------------------- ------------
 ``pydocstyle`` Runs pydocstyle.

diff --git a/airflow/providers/google/provider.yaml b/airflow/providers/google/provider.yaml
@@ -394,6 +394,9 @@ sensors:
  - integration-name: Google Campaign Manager
  python-modules:
  - airflow.providers.google.marketing_platform.sensors.campaign_manager
+ - integration-name: Google Dataflow
+ python-modules:
+ - airflow.providers.google.cloud.sensors.dataflow
  - integration-name: Google Display&Video 360
  python-modules:
  - airflow.providers.google.marketing_platform.sensors.display_video

diff --git a/breeze-complete b/breeze-complete
@@ -109,6 +109,7 @@ no-relative-imports
 pre-commit-descriptions
 provide-create-sessions
 providers-init-file
+provider-yamls
 pydevd
 pydocstyle
 pylint

diff --git a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements. See the NOTICE file
 # distributed with this work for additional information