Make executemany keyword arguments only in DbApiHook.insert_rows (#…

…37840) * Make `executemany` keyword arguments only in `DbApiHook.insert_rows` * Change stubs file signature for insert_rows
apache · Mar 1, 2024 · 2ab6081 · 2ab6081
1 parent e1f60bf
commit 2ab6081
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/airflow/providers/common/sql/hooks/sql.py b/airflow/providers/common/sql/hooks/sql.py
@@ -516,7 +516,15 @@ def _generate_insert_sql(self, table, values, target_fields, replace, **kwargs)
  return self._replace_statement_format.format(table, target_fields, ",".join(placeholders))
 
  def insert_rows(
- self, table, rows, target_fields=None, commit_every=1000, replace=False, executemany=False, **kwargs
+ self,
+ table,
+ rows,
+ target_fields=None,
+ commit_every=1000,
+ replace=False,
+ *,
+ executemany=False,
+ **kwargs,
  ):
  """Insert a collection of tuples into a table.
 

diff --git a/airflow/providers/common/sql/hooks/sql.pyi b/airflow/providers/common/sql/hooks/sql.pyi
@@ -93,6 +93,8 @@ class DbApiHook(BaseForDbApiHook):
  target_fields: Incomplete | None = ...,
  commit_every: int = ...,
  replace: bool = ...,
+ *,
+ executemany: bool = ...,
  **kwargs,
  ) -> None: ...
  def bulk_dump(self, table, tmp_file) -> None: ...

diff --git a/airflow/providers/google/cloud/hooks/bigquery.py b/airflow/providers/google/cloud/hooks/bigquery.py
@@ -232,8 +232,6 @@ def insert_rows(
  target_fields: Any = None,
  commit_every: Any = 1000,
  replace: Any = False,
- *,
- executemany=False,
  **kwargs,
  ) -> None:
  """Insert rows.