Skip to content

docs(docs-infra): replace deprecated RouterTestingModule with RouterM… #62364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

docs(docs-infra): replace deprecated RouterTestingModule with RouterM… #62364

wants to merge 2 commits into from
+28 −20

Conversation

akib1997
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Replace deprecated RouterTestingModule with RouterModule.forRoot([])

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Uses deprecated RouterTestingModule

Issue Number: N/A

What is the new behavior?

Replace deprecated RouterTestingModule with RouterModule.forRoot([])

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alan-agius4 June 29, 2025 18:06
@ngbot ngbot bot added this to the Backlog milestone Jun 29, 2025
JeanMeche
JeanMeche requested changes Jun 29, 2025
View reviewed changes
@JeanMeche JeanMeche requested review from JeanMeche and removed request for alan-agius4 June 29, 2025 18:10
@JeanMeche
Copy link
Member

JeanMeche commented Jun 29, 2025 •
edited
Loading

Could you also please reword the commit to docs(docs-infra): ..., this isn't a router package related change. Thank you.

@akib1997 akib1997 force-pushed the refactor/replace-router-testing-module-by-router-module branch from fed1c17 to 8040816 Compare June 29, 2025 18:49
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jun 29, 2025
@thePunderWoman thePunderWoman changed the title refactor(router): replace deprecated RouterTestingModule with RouterM… docs(docs-infra): replace deprecated RouterTestingModule with RouterM… Jun 30, 2025
@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release and removed area: router labels Jun 30, 2025
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jul 2, 2025
thePunderWoman pushed a commit that referenced this pull request Jul 2, 2025
@akib1997 @thePunderWoman
docs(docs-infra): replace deprecated RouterTestingModule with RouterM…
6016e4f 
…odule.forRoot([]) (#62364)

PR Close #62364
thePunderWoman pushed a commit that referenced this pull request Jul 2, 2025
@akib1997 @thePunderWoman
docs(docs-infra): replace deprecated RouterTestingModule with RouterM…
59983ef 
…odule.forRoot([]) (#62364)

PR Close #62364
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit cd87a71.

The changes were merged into the following branches: main, 20.0.x, 20.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@akib1997 @JeanMeche @thePunderWoman