docs(docs-infra): replace deprecated RouterTestingModule with RouterM… #62364
+19
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
requested changes
Jun 29, 2025
adev/shared-docs/components/breadcrumb/breadcrumb.component.spec.ts
Outdated
Show resolved
Hide resolved
|
Could you also please reword the commit to |
…odule.forRoot([])
fed1c17 to
8040816
Compare
JeanMeche
reviewed
Jun 30, 2025
| @@ -23,7 +23,7 @@ describe('Breadcrumb', () => { | |||
| navigationStateSpy = jasmine.createSpyObj('NavigationState', ['activeNavigationItem']); | |||
|
|
|||
| TestBed.configureTestingModule({ | |||
| imports: [Breadcrumb, RouterTestingModule], | |||
| imports: [Breadcrumb, provideRouter([])], | |||
There was a problem hiding this comment.
provideRouter is a provider, not an something we import, could you please fix that. Thank you.
There was a problem hiding this comment.
provideRouteris a provider, not an something we import, could you please fix that. Thank you.
Oops, sorry—I forgot about that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Replace deprecated RouterTestingModule with RouterModule.forRoot([])
What is the current behavior?
Uses deprecated RouterTestingModule
Issue Number: N/A
What is the new behavior?
Replace deprecated RouterTestingModule with RouterModule.forRoot([])
Does this PR introduce a breaking change?