Extract audio type from TS descriptors #973
Merged
+818
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The audio type of the stream is defined by ISO/IEC 13818-1 in section 2.6.18.
4a6458e
to
6aeb503
Compare
6aeb503
to
7e21da8
Compare
|
Have moved the I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
1632336
to
4940c18
Compare
4940c18
to
50385be
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audio type of the stream, as defined by ISO/IEC 13818-1 in section 2.6.18, can be mapped to RoleFlags. Then this information can be used by the user for better selection of audio stream.
Real UC: source contains two audio streams, both are in the same language. One of them is intended for visually impaired viewer. With information about audio type, the user can better decide which stream he wants to hear.
As audio type can be mapped to RoleFlags, I have decided not to extends Format class.