Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ClearKey DRM invalid URL workaround for Android 13 and newer #837

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Apply ClearKey DRM invalid URL workaround for Android 13 and newer #837

merged 2 commits into from
Nov 27, 2023

Conversation

superjohan
Copy link
Contributor

At least some Android 14 devices still have the same invalid URL issue when using ClearKey DRM, so might as well apply the check to newer versions of Android as well. We have seen this in the wild on Samsung S23 series devices at least.

Original fix: 715c948

@icbaker icbaker self-assigned this Nov 24, 2023
@icbaker icbaker self-requested a review November 24, 2023 11:32
@icbaker
Copy link
Collaborator

icbaker commented Nov 27, 2023

Thanks for flagging this, I've confirmed I see the same behaviour on a Samsung S23+ running Android 14 (samsung/dm2qxxx/dm2q:14/UP1A.230623.007/S916BXXU3ZWH8:user/release-keys). I've queried with the DRM team whether there's another way we can determine if a device has this fix present or not (and therefore the workaround shouldn't be needed). In the meantime, the workaround seems very safe to apply on all devices >= 33, since it will only 'break' a playback if the real license URL is exactly https://default.url (no path).

I'll get this change merged.

superjohan and others added 2 commits November 27, 2023 10:41
@superjohan @icbaker
Apply workaround for Android 13 and newer
ad7b12e 
At least some Android 14 devices still have the same invalid URL issue
when using ClearKey DRM, so might as well apply the check to newer
versions of Android as well.
@icbaker
Add release note for clearkey workaround change
8e4ffe7
@copybara-service copybara-service bot merged commit 5f27b18 into androidx:main Nov 27, 2023
1 check passed
@superjohan superjohan deleted the fix/android-14-clearkey branch November 27, 2023 14:59
microkatz pushed a commit that referenced this pull request Jan 11, 2024
@microkatz
Merge pull request #837 from superjohan:fix/android-14-clearkey
db64831 
PiperOrigin-RevId: 585639025
(cherry picked from commit 5f27b18)
@androidx androidx locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@icbaker icbaker Awaiting requested review from icbaker

Assignees

@icbaker icbaker

Labels
should merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@superjohan @icbaker