Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long opus buffers very slowly #391

Closed
1 task
PaulWoitaschek opened this issue May 14, 2023 · 4 comments
Closed
1 task

Long opus buffers very slowly #391

PaulWoitaschek opened this issue May 14, 2023 · 4 comments
Assignees
@christosts
Labels
bug needs triage

Comments

@PaulWoitaschek
Copy link
Contributor

Media3 Version

Media3 1.0.1

Devices that reproduce the issue

  • Pixel 7 running Android 13
  • Emulators

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

  1. Play the attached file in the demo app
  2. Seek to hour 35

Expected result

The playback start immediately

Actual result

The playback doesn't start at all or starts after several minutes.

If in the range of < 20h the playback starts immediately on seeking. After the 25h mark it's getting very very slow.

Media

Sent by mail

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@PaulWoitaschek PaulWoitaschek mentioned this issue May 14, 2023
Closed
@PaulWoitaschek
Copy link
Contributor Author

Also see PaulWoitaschek/Voice#1653 for the original bug report and some theories by @zsln

@christosts
Copy link
Contributor

I can reproduce it with v1.0.1. There is a wrong calculation when calculating the seek point, a long is overflowing. I'll prepare a fix.

@christosts
Copy link
Contributor

I added the fix and plan to be included in the next release. This issue should be automatically linked with the commit once the code is pushed to the main branch - that will be a signal for you if you want to try it out immediately by depending on the project sources.

I'll close the issue too, please feel free to comment or re-open if the fix is not addressing your issue. Thanks.

@PaulWoitaschek
Copy link
Contributor Author

Thanks a lot!

tonihei pushed a commit that referenced this issue May 24, 2023
@christosts @tonihei
Fix seeking bug in opus
b9a4e61 
Fix a bug when seeking in an opus container. The calculations inside
DefaultOggSeeker may overflow a long primitive.

Issue: #391

#minor-release

PiperOrigin-RevId: 534128513
tonihei pushed a commit to google/ExoPlayer that referenced this issue May 24, 2023
@christosts @tonihei
Fix seeking bug in opus
5535cd1 
Fix a bug when seeking in an opus container. The calculations inside
DefaultOggSeeker may overflow a long primitive.

Issue: androidx/media#391

#minor-release

PiperOrigin-RevId: 534128513
tof-tof pushed a commit that referenced this issue May 30, 2023
@christosts @tof-tof
Fix seeking bug in opus
fbd0bae 
Fix a bug when seeking in an opus container. The calculations inside
DefaultOggSeeker may overflow a long primitive.

Issue: #391

#minor-release

PiperOrigin-RevId: 534128513
(cherry picked from commit b9a4e61)
tof-tof pushed a commit to google/ExoPlayer that referenced this issue Jun 14, 2023
@christosts @tof-tof
Fix seeking bug in opus
85a9d56 
Fix a bug when seeking in an opus container. The calculations inside
DefaultOggSeeker may overflow a long primitive.

Issue: androidx/media#391

#minor-release

PiperOrigin-RevId: 534128513
(cherry picked from commit 5535cd1)
@androidx androidx locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christosts christosts

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulWoitaschek @christosts