Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call MediaControllerCompat.Callback#onSessionEvent from MediaLibraryService #293

Closed
Yangwoqizuo opened this issue Apr 4, 2023 · 1 comment
Closed

Call MediaControllerCompat.Callback#onSessionEvent from MediaLibraryService #293

Yangwoqizuo opened this issue Apr 4, 2023 · 1 comment
Assignees
@tonihei
Labels
bug

Comments

@Yangwoqizuo
Copy link

A function calling onSessionEvent is needed(maybe broadcastCustomCommand?)
PS:
MediaControllerImplLegacy#onSessionEvent will call onCustomCommand(means MediaBrowserService can call Media3's onCustomCommand)
, so is there any way to let MediaLibraryService call MediaControllerCompat.Callback#onSessionEvent?
(Media3's MediaLibraryService call legacy MediaController's onSessionEvent)
@tonihei tonihei self-assigned this Apr 4, 2023
@tonihei
Copy link
Collaborator

tonihei commented Apr 4, 2023 •
edited

Thanks for the request! This looks like an oversight that should be added to the library as you described. I'll mark it as a bug and we can fix it in the next release.

marcbaechinger pushed a commit that referenced this issue Apr 5, 2023
@tonihei @marcbaechinger
Implement missing broadcastCustomCommand to legacy controller
502969a 
And also mention a few restrictions regarding legacy components
in Javadoc.

#minor-release

Issue: #293
PiperOrigin-RevId: 522005562
@tonihei tonihei closed this as completed Apr 11, 2023
rohitjoins pushed a commit that referenced this issue Apr 18, 2023
@tonihei @rohitjoins
Implement missing broadcastCustomCommand to legacy controller
5d11aa9 
And also mention a few restrictions regarding legacy components
in Javadoc.

Issue: #293
PiperOrigin-RevId: 522005562
(cherry picked from commit 502969a)
@androidx androidx locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tonihei tonihei

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonihei @Yangwoqizuo