-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMCD] - Update Custom key pattern to match what spec allows #1028
Labels
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Feb 6, 2024
Relax the regex to only check for hyphen which is required by the specification. Issue: #1028 #minor-release PiperOrigin-RevId: 604719300
copybara-service bot
pushed a commit
to google/ExoPlayer
that referenced
this issue
Feb 6, 2024
Relax the regex to only check for hyphen which is required by the specification. Issue: androidx/media#1028 #minor-release PiperOrigin-RevId: 604719300
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Use case description
Noticed that the
CUSTOM_KEY_NAME_PATTERN
regex inCmcdData
class is not compliant to spec where it states that "ClientsSHOULD use a reverse-DNS syntax when defining their own prefix" when defining custom CMCD keys. Custom key examples of this syntax in spec, such as
com.example-myNumericKey=500
, causes errors due to it not matching the pattern. I've personally come acrossExoPlaybackException: Unexpected runtime error
caused byIllegalStateException
atvalidateCustomDataListFormat
method when trying to play some content.Proposed solution
Update in
CmcdData
class:Validated that this pattern allows reverse-DNS syntax and hyphen is still required.
Valid examples:
Alternatives considered
N/A
The text was updated successfully, but these errors were encountered: