Make paging-testing multiplatform with only a JVM implementation
#586
Conversation
| import androidx.build.Publish | ||
|
|
||
| plugins { | ||
| id("AndroidXPlugin") | ||
| id("com.android.library") | ||
| id("org.jetbrains.kotlin.android") |
There was a problem hiding this comment.
I think we need to continue targeting android because the first stable version is to be released with android support. @ianhanniballake What are your thoughts on this?
There was a problem hiding this comment.
Given that these are testing paging-common APIs, I think it makes to match the same set of targets.
There was a problem hiding this comment.
@veyndan We are in the process of refactoring Logger in paging-common with added android target so paging-common will become an android library. Working on the CL as we speak, should be up today. I'll cc you on it.
There was a problem hiding this comment.
I've updated paging-common into an android library now.
There was a problem hiding this comment.
Just updated the PR to add back the android target!
01c6cda
to
ccf7f1d
Compare
| implementation(project(":paging:paging-common")) | ||
| } | ||
| } | ||
| jvmTest { |
There was a problem hiding this comment.
Does command ./gradlew paging:paging-testing:connectedCheck still run successfully? I know we don't have android tests but in paging-common I had to add android-specific test dependencies or else connectCheck task errors out. Not sure if we need it for paging-testing.
There was a problem hiding this comment.
I just ran it and it completed successfully
ccf7f1d
to
7250175
Compare
Test: ./gradlew paging:paging-testing:allTests