[Navigation] Make NamedNavArgument's fields public #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons as public Test: N/A Fixes: b/181320559 Change-Id: I744feff9aca40e910c622f0c61a39a005e5f6f68
ianhanniballake
requested changes
May 5, 2021
| @@ -33,9 +33,9 @@ public fun navArgument( | |||
| * Construct a named [NavArgument] by using the [navArgument] method. | |||
| */ | |||
| public class NamedNavArgument internal constructor( | |||
| private val name: String, | |||
| private val argument: NavArgument | |||
| public val name: String, | |||
There was a problem hiding this comment.
Please add KDocs to this and the other methods
ianhanniballake
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Relnote: NamedNavArgument's
name,argumentand destructuring functions are now publicTesting
Test: N/A
Issues Fixed
Fixes: b/181320559