Navigation: Allow parsing a NavType#ReferenceType from String
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavType#ReferenceType from StringNavType#ReferenceType from String
jbw0033
requested changes
Feb 8, 2021
navigation/navigation-common/src/androidTest/res/values/ids.xml
Outdated
Show resolved
Hide resolved
jbw0033
approved these changes
Feb 9, 2021
ianhanniballake
requested changes
Feb 9, 2021
navigation/navigation-common/src/main/java/androidx/navigation/NavType.java
Outdated
Show resolved
Hide resolved
…se-reference-navtype
… into parse-reference-navtype
Looks like some part of the build chain is having a bad day -- I'll attempt to rebuild tomorrow, but these changes compile on my local machine FWIW |
ianhanniballake
approved these changes
Feb 10, 2021
|
Yep, we're having some internal infrastructure fun times at the moment. Code looks good here though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Bundle contents can be extracted as a Reference, allow parsing the Bundle contents as a Reference.
When navigating via deeplink URI, the user is required to string-ify navigation arguments in order to append them to the URI as query parameters. This PR supports retrieving a Reference type from a Bundle
Proposed Changes
NavType#ReferenceType::parseValue's method functionality withInteger.parseIntTesting
Updated
NavTypeTestto validate that reference types can be inserted and retrieved from a Bundle.Test: /gradlew test connectedCheck
Issues Fixed
Fixes: b/179166693