Add listener graceful termination period and background context after the message is received #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link-
previously approved these changes
Jan 25, 2024
2935777
to
a65c7bf
Compare
Link-
approved these changes
Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listener can be interrupted at any point of upgrade. If interrupted at a time when the listener receives a message, acquires jobs but fails to patch, that may cause some jobs to be left in a scheduled state.
This PR intends to replace context after the message is received, and to allow some period for the listener to actually patch the ephemeral runner set. Only after patching, the listener should return and therefore exit.