mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline event handlers refactoring #551
Open
enricocarraro
wants to merge
77
commits into
WordPress:master
Choose a base branch
from
enricocarraro:inline_event_handlers_refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Inline event handlers refactoring #551
enricocarraro
wants to merge
77
commits into
WordPress:master
from
enricocarraro:inline_event_handlers_refactoring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
wp_die( $api->get_error_message() . '</p> <p><a href="#" onclick="document.location.reload(); return false;">' . __( 'Try Again' ) . '</a>' ); | ||
wp_die( $api->get_error_message() . '</p> <p><a href="#" id="theme-try-again">' . __( 'Try Again' ) . '</a>' ); | ||
|
||
$js = <<<'JS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this can't be in an external file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find instances of this method being used, so I moved the handler to an inline script for simplicity.
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 24, 2020
swissspidy
reviewed
Sep 25, 2020
swissspidy
reviewed
Sep 25, 2020
Ayesh
reviewed
Sep 30, 2020
swissspidy
reviewed
Oct 5, 2020
swissspidy
reviewed
Oct 5, 2020
enricocarraro
force-pushed
the
inline_event_handlers_refactoring
branch
2 times, most recently
from
October 8, 2020 11:03
f6bfa19
to
ec4f41d
Compare
vrana
reviewed
Oct 8, 2020
enricocarraro
force-pushed
the
inline_event_handlers_refactoring
branch
2 times, most recently
from
October 8, 2020 20:21
dbdef78
to
43b4fac
Compare
enricocarraro
force-pushed
the
inline_event_handlers_refactoring
branch
2 times, most recently
from
October 15, 2020 14:42
cfddf14
to
f67e4ba
Compare
enricocarraro
force-pushed
the
inline_event_handlers_refactoring
branch
5 times, most recently
from
October 20, 2020 08:30
75d9ecd
to
c2550c2
Compare
…dit-form-advanced.php`.
…dmin-header.php`.
…dmin-footer.php`.
…s/functions.php`.
…mage-header.php` with event handler in `js/_enqueues/admin/custom-header.js`.
…h event handler in `js/_enqueues/admin/edit-comments.js`.
…t-table.php` with event handler in `js/_enqueues/admin/link-manager.js`.
…es/meta-boxes.php` with event handler in `src/js/_enqueues/admin/link.js`.
…t-table.php` with event handler in `js/_enqueues/admin/media.js`.
…h event handler in `js/_enqueues/admin/post.js`.
…t handler in `js/_enqueues/admin/setup-config.js`.
…st-table.php` with event handler in `js/_enqueues/admin/themes-list.js`.
…` and `src/wp-admin/includes/post.php` with event handler in `wp-includes/js/metabox-events.js`.
…enus.php` with event handler in `js/_enqueues/wp/customize/nav-menus.js`.
…u-widget.php` with event handler in `js/_enqueues/wp/customize/widgets.js`.
…tall-list-table.php` with event handler in inline script.
… event handler in inline script.
…th event handler in inline script.
…handler in inline script.
…t handler in inline script.
…` with event handler in `js/_enqueues/lib/image-edit.js`.
…ent handler in `js/_enqueues/admin/media-events.js`.
…includes/ms.php` with event handler in `js/_enqueues/admin/common.js`.
…dmin/plugin-editor.php` with event handler in `js/_enqueues/wp/theme-plugin-editor.js`.
enricocarraro
force-pushed
the
inline_event_handlers_refactoring
branch
from
October 23, 2020 13:07
c2550c2
to
311cf6a
Compare
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/51407
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.