[WPE] Click count leaking through successive layout test within the same WPEView #47417
Conversation
|
EWS run on previous version of this PR (hash 17c9db0) |
🛠 🧪 jsc| * wpe_view_clear_press_count | ||
| * @view: a #WPEView | ||
| * | ||
| * Clear any button press being tracket. |
| @@ -138,6 +138,7 @@ WPE_API guint wpe_view_compute_press_count (WPEView | |||
| gdouble y, | |||
| guint button, | |||
| guint32 time); | |||
| WPE_API void wpe_view_clear_press_count (WPEView *view); | |||
There was a problem hiding this comment.
It seems counter-intuitive that an external entity has to tell the view that it has to clear something, because of a navigation/load action. I guess there is never a situation where we want to preserve that press count between such events, no?
There was a problem hiding this comment.
IIUC, WPEView is in charge of lower level operations like delivering events to the WebKitWebView and forwarding buffers received from it. Something like a "shell" around WebKitWebView. So, WPEView would not have knowledge of web operations like loading, navigation, etc.
Maybe instead of the EventSender directly calling this new function, should we make WebKitWebView call it when those cases happen, like loading a new page?
Another option, if we want to avoid creating a new function, would be creating something like a WPEEventType::WPE_EVENT_RESET, that, when sent through wpe_view_event(event), tells the WPEView to reset its event state tracking.
17c9db0 to
3d6d515
Compare
|
EWS run on previous version of this PR (hash 3d6d515)
|
…ame WPEView https://bugs.webkit.org/show_bug.cgi?id=295252 Reviewed by NOBODY (OOPS!). Add a new function to reset click count tracking between tests, avoiding accidental double and triple clicks. Found this issue while rebaselining the fast/html/details-* tests after 296203@main. Some rebaselines were flaky as the tests were affected by this when running together. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_clear_press_count): Added. * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp: (WTR::TestController::platformConfigureViewForTest): Reset click count between tests.
3d6d515 to
9d8a6e6
Compare
|
EWS run on current version of this PR (hash 9d8a6e6) |
|
Code ready for review, will update with the related baselines (s/selection/caret) after #47433 lands |
9d8a6e6
9d8a6e6