[WPE] Click count leaking through successive layout test within the same WPEView #47417
+987
−964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame WPEView https://bugs.webkit.org/show_bug.cgi?id=295252 Reviewed by NOBODY (OOPS!). Add a new function to reset click count tracking between tests, avoiding accidental double and triple clicks. Found this issue while rebaselining the fast/html/details-* tests after 296203@main. Some rebaselines were flaky as the tests were affected by this when running together. * LayoutTests/platform/glib/fast/html/details-*-expected.txt: Rebaselined. * LayoutTests/platform/gtk/fast/html/details-*-expected.txt: Rebaselined. * LayoutTests/platform/wpe/fast/html/details-*-expected.txt: Rebaselined. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_clear_press_count): Added. * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp: (WTR::TestController::platformConfigureViewForTest): Reset click count between tests.
|
EWS run on current version of this PR (hash 17c9db0) |
🛠 🧪 jsc| * wpe_view_clear_press_count | ||
| * @view: a #WPEView | ||
| * | ||
| * Clear any button press being tracket. |
| @@ -138,6 +138,7 @@ WPE_API guint wpe_view_compute_press_count (WPEView | |||
| gdouble y, | |||
| guint button, | |||
| guint32 time); | |||
| WPE_API void wpe_view_clear_press_count (WPEView *view); | |||
There was a problem hiding this comment.
It seems counter-intuitive that an external entity has to tell the view that it has to clear something, because of a navigation/load action. I guess there is never a situation where we want to preserve that press count between such events, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17c9db0
17c9db0