Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][MediaStream] Set a non constant groupId on streams emitted by webkitmediastreamsrc #30041

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[GStreamer][MediaStream] Set a non constant groupId on streams emitted by webkitmediastreamsrc #30041

merged 1 commit into from
Jun 27, 2024
+3 −1

Conversation

philn
Copy link
Member

@philn philn commented Jun 21, 2024 •
edited by webkit-early-warning-system
Loading

c1fba8f

[GStreamer][MediaStream] Set a non constant groupId on streams emitted by webkitmediastreamsrc
https://bugs.webkit.org/show_bug.cgi?id=275734

Reviewed by Xabier Rodriguez-Calvar.

While hardcoding 1 as group-id hasn't created issues in practice, it's not semantically correct, a
unique groupId should be used.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcConstructed):
(webkitMediaStreamSrcAddTrack):

Canonical link: https://commits.webkit.org/280411@main

aed6f29

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Jun 21, 2024
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jun 21, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 21, 2024 •
edited
Loading

EWS run on current version of this PR (hash aed6f29)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn requested a review from calvaris June 21, 2024 12:24
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 21, 2024
@philn
Copy link
Member Author

philn commented Jun 26, 2024

Ping?

@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 27, 2024
@philn
[GStreamer][MediaStream] Set a non constant groupId on streams emitte…
c1fba8f 
…d by webkitmediastreamsrc

https://bugs.webkit.org/show_bug.cgi?id=275734

Reviewed by Xabier Rodriguez-Calvar.

While hardcoding 1 as group-id hasn't created issues in practice, it's not semantically correct, a
unique groupId should be used.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcConstructed):
(webkitMediaStreamSrcAddTrack):

Canonical link: https://commits.webkit.org/280411@main
@webkit-commit-queue
Copy link
Collaborator

Committed 280411@main (c1fba8f): https://commits.webkit.org/280411@main

Reviewed commits have been landed. Closing PR #30041 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c1fba8f into WebKit:main Jun 27, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2024
@philn philn deleted the eng/275734 branch June 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
5 participants
@philn @webkit-early-warning-system @webkit-commit-queue @calvaris @webkit-ews-buildbot