Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed, test is too slow, reducing cost #30027

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Unreviewed, test is too slow, reducing cost #30027

merged 1 commit into from
Jun 20, 2024
+15 −17

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 20, 2024 •
edited by webkit-early-warning-system
Loading

fcb5adc

Unreviewed, test is too slow, reducing cost
https://bugs.webkit.org/show_bug.cgi?id=275716
rdar://130240478

JSTests/wasm/references/externref_table_import.js is unnecessarily costly and failing to run due to incredibly long runtime.
We should not create such a test. This patch fixes it.

* JSTests/wasm/references/externref_table_import.js:
(fullGC.assert.eq):

Canonical link: https://commits.webkit.org/280232@main

e7cebe3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 🧪 jsc-arm64 ⏳ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge   🛠 tv   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@Constellation Constellation requested a review from a team as a code owner June 20, 2024 23:47
@Constellation Constellation self-assigned this Jun 20, 2024
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 20, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 20, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 458e6b4)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🛠 jsc-armv7
❌ 🛠 🧪 unsafe-merge   🛠 tv   🧪 jsc-armv7-tests
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #30027

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 20, 2024
@Constellation Constellation removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2024
@Constellation Constellation changed the title Unreviewd, test is too slow, reducing cost Unreviewed, test is too slow, reducing cost Jun 20, 2024
@Constellation Constellation force-pushed the eng/Unreviewd-test-is-too-slow-reducing-cost branch from 458e6b4 to e7cebe3 Compare June 20, 2024 23:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 20, 2024 •
edited
Loading

EWS run on current version of this PR (hash e7cebe3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 🧪 jsc-arm64 ⏳ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge   🛠 tv   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
@Constellation
Unreviewed, test is too slow, reducing cost
fcb5adc 
https://bugs.webkit.org/show_bug.cgi?id=275716
rdar://130240478

JSTests/wasm/references/externref_table_import.js is unnecessarily costly and failing to run due to incredibly long runtime.
We should not create such a test. This patch fixes it.

* JSTests/wasm/references/externref_table_import.js:
(fullGC.assert.eq):

Canonical link: https://commits.webkit.org/280232@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewd-test-is-too-slow-reducing-cost branch from e7cebe3 to fcb5adc Compare June 20, 2024 23:53
@webkit-commit-queue
Copy link
Collaborator

Committed 280232@main (fcb5adc): https://commits.webkit.org/280232@main

Reviewed commits have been landed. Closing PR #30027 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fcb5adc into WebKit:main Jun 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
3 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue