Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Simplify resolve_scope for ClosureVar #29987

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[JSC] Simplify resolve_scope for ClosureVar #29987

merged 1 commit into from
Jun 20, 2024
+11 −6

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 19, 2024 •
edited by webkit-early-warning-system

2cf423a

[JSC] Simplify resolve_scope for ClosureVar
https://bugs.webkit.org/show_bug.cgi?id=275671
rdar://130166983

Reviewed by Justin Michaud.

Due to profiled result, we already know local scope depth at this point.
Emit sequence of load instead of loop for smaller local scope depth.

* Source/JavaScriptCore/jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):

Canonical link: https://commits.webkit.org/280191@main

48272ab

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation requested a review from a team as a code owner June 19, 2024 21:30
@Constellation Constellation self-assigned this Jun 19, 2024
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 19, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 48272ab)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

justinmichaud
justinmichaud approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
@Constellation
[JSC] Simplify resolve_scope for ClosureVar
2cf423a 
https://bugs.webkit.org/show_bug.cgi?id=275671
rdar://130166983

Reviewed by Justin Michaud.

Due to profiled result, we already know local scope depth at this point.
Emit sequence of load instead of loop for smaller local scope depth.

* Source/JavaScriptCore/jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):

Canonical link: https://commits.webkit.org/280191@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Simplify-resolve_scope-for-ClosureVar branch from 48272ab to 2cf423a Compare June 20, 2024 05:45
@webkit-commit-queue
Copy link
Collaborator

Committed 280191@main (2cf423a): https://commits.webkit.org/280191@main

Reviewed commits have been landed. Closing PR #29987 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2cf423a into WebKit:main Jun 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @justinmichaud