Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvOS] Enable MediaSource #29944

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[tvOS] Enable MediaSource #29944

merged 1 commit into from
Jun 18, 2024
+6 −1

Conversation

aestes
Copy link
Contributor

@aestes aestes commented Jun 18, 2024 •
edited by webkit-early-warning-system

f875026

[tvOS] Enable MediaSource
https://bugs.webkit.org/show_bug.cgi?id=275628
rdar://129307796

Reviewed by Eric Carlson.

Enabled MediaSource at runtime on tvOS.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:
(WebKit::defaultMediaSourceEnabled):

Canonical link: https://commits.webkit.org/280138@main

525c85d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
loading 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 tv   🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aestes aestes self-assigned this Jun 18, 2024
@aestes aestes added the Media Bugs related to the HTML 5 Media elements. label Jun 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 525c85d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
loading 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2   🛠 jsc-armv7
✅ 🛠 tv   🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aestes aestes requested review from a team and pxlcoder June 18, 2024 19:51
@aestes aestes mentioned this pull request Jun 18, 2024
Closed
@aestes aestes added the merge-queue Applied to send a pull request to merge-queue label Jun 18, 2024
@aestes
[tvOS] Enable MediaSource
f875026 
https://bugs.webkit.org/show_bug.cgi?id=275628
rdar://129307796

Reviewed by Eric Carlson.

Enabled MediaSource at runtime on tvOS.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm:
(WebKit::defaultMediaSourceEnabled):

Canonical link: https://commits.webkit.org/280138@main
@webkit-commit-queue
Copy link
Collaborator

Committed 280138@main (f875026): https://commits.webkit.org/280138@main

Reviewed commits have been landed. Closing PR #29944 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f875026 into WebKit:main Jun 18, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@aestes aestes

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@aestes @webkit-early-warning-system @webkit-commit-queue @eric-carlson