Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] Metal compiler error message can expose privacy sensitive information #29942

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[WebGPU] Metal compiler error message can expose privacy sensitive information #29942

merged 1 commit into from
Jun 20, 2024
+71 −1

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jun 18, 2024 •
edited by webkit-early-warning-system

95f9534

[WebGPU] Metal compiler error message can expose privacy sensitive information
https://bugs.webkit.org/show_bug.cgi?id=275624
<radar://130065215>

Reviewed by Dan Glastonbury.

Metal compilation error message was leaking privacy sensitive information.

* LayoutTests/TestExpectations:
Skip for debug as we print privacy sensitive information in debug.

* LayoutTests/fast/webgpu/regression/repro_275624-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275624.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::createLibrary):

Canonical link: https://commits.webkit.org/280202@main

758ab02

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jun 18, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jun 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 940219a)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski requested a review from djg June 18, 2024 18:29
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 18, 2024
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Jun 18, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Metal-compiler-error-message-can-expose-privacy-sensitive-information branch from 940219a to 758ab02 Compare June 18, 2024 23:12
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 758ab02)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

djg
djg approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jun 20, 2024
@mwyrzykowski
[WebGPU] Metal compiler error message can expose privacy sensitive in…
95f9534 
…formation

https://bugs.webkit.org/show_bug.cgi?id=275624
<radar://130065215>

Reviewed by Dan Glastonbury.

Metal compilation error message was leaking privacy sensitive information.

* LayoutTests/TestExpectations:
Skip for debug as we print privacy sensitive information in debug.

* LayoutTests/fast/webgpu/regression/repro_275624-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275624.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::createLibrary):

Canonical link: https://commits.webkit.org/280202@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Metal-compiler-error-message-can-expose-privacy-sensitive-information branch from 758ab02 to 95f9534 Compare June 20, 2024 16:05
@webkit-commit-queue
Copy link
Collaborator

Committed 280202@main (95f9534): https://commits.webkit.org/280202@main

Reviewed commits have been landed. Closing PR #29942 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 95f9534 into WebKit:main Jun 20, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djg djg djg approved these changes

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo tadeuzagallo is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @djg @webkit-ews-buildbot