Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureSource #29815

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureSource #29815

merged 1 commit into from
Jun 14, 2024

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jun 14, 2024 •
edited by webkit-early-warning-system

dcc6c16

Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=275476
rdar://129801303

Reviewed by Eric Carlson.

We partially revert https://commits.webkit.org/277415@main, as it reintroduce the crash for safari view services.
We disable the checks specifically for iOS simulator, since there is no support for media endowments.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::startProducingData):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::startProducingData):

Canonical link: https://commits.webkit.org/280020@main

0d84203

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf self-assigned this Jun 14, 2024
@youennf youennf added the WebRTC For bugs in WebRTC label Jun 14, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0d84203)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf marked this pull request as ready for review June 14, 2024 10:39
@youennf youennf requested a review from cdumez as a code owner June 14, 2024 10:39
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2024
@youennf
Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureS…
dcc6c16 
…ource

https://bugs.webkit.org/show_bug.cgi?id=275476
rdar://129801303

Reviewed by Eric Carlson.

We partially revert https://commits.webkit.org/277415@main, as it reintroduce the crash for safari view services.
We disable the checks specifically for iOS simulator, since there is no support for media endowments.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::startProducingData):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::startProducingData):

Canonical link: https://commits.webkit.org/280020@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Prevent-crash-when-calling-AVCaptureSession-init-in-AVVideoCaptureSource branch from 0d84203 to dcc6c16 Compare June 14, 2024 16:31
@webkit-commit-queue
Copy link
Collaborator

Committed 280020@main (dcc6c16): https://commits.webkit.org/280020@main

Reviewed commits have been landed. Closing PR #29815 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dcc6c16 into WebKit:main Jun 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa

@aestes aestes Awaiting requested review from aestes

Assignees

@youennf youennf

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
4 participants
@youennf @webkit-early-warning-system @webkit-commit-queue @eric-carlson