Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win] Update intrinsic device scale factor dynamically #29810

Conversation

khei4
Copy link
Contributor

@khei4 khei4 commented Jun 14, 2024

50c1741

[Win] Update intrinsic device scale factor dynamically
https://bugs.webkit.org/show_bug.cgi?id=274377

Reviewed by Fujii Hironori.

When intrinsic device scale factor dynamically is changed, i.e. moving
between different displays, we need to change intrinsic device scale
factor and repaint contents.
For main web contents, although WebView can't receive WM_DPICHANGED by
default, it's sufficient to update on WM_SIZE handler
because MainWindow's WM_DPICHANGED handling contains resizing window.
Above change also enables WebInspector resize when receiving WM_DPICHANGED,
just as MainWindow does.

    * Source\WebKit\UIProcess\Inspector\win\WebInspectorUIProxyWin.cpp:
    * Source\WebKit\UIProcess\win\WebView.cpp:

Canonical link: https://commits.webkit.org/280003@main

f872c75

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2 βœ… πŸ§ͺ wincairo-tests
  πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ›  wpe-cairo
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
  πŸ›  tv-sim   πŸ§ͺ mac-wk2-stress   πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@khei4 khei4 force-pushed the eng/Win-Update-intrinsic-device-scale-factor-dynamically branch from 3d33eed to f872c75 Compare June 14, 2024 07:51
@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=274377

Reviewed by Fujii Hironori.

When intrinsic device scale factor dynamically is changed, i.e. moving
between different displays, we need to change intrinsic device scale
factor and repaint contents.
For main web contents, although WebView can't receive WM_DPICHANGED by
default, it's sufficient to update on WM_SIZE handler
because MainWindow's WM_DPICHANGED handling contains resizing window.
Above change also enables WebInspector resize when receiving WM_DPICHANGED,
just as MainWindow does.

    * Source\WebKit\UIProcess\Inspector\win\WebInspectorUIProxyWin.cpp:
    * Source\WebKit\UIProcess\win\WebView.cpp:

Canonical link: https://commits.webkit.org/280003@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Win-Update-intrinsic-device-scale-factor-dynamically branch from f872c75 to 50c1741 Compare June 14, 2024 07:58
@webkit-commit-queue
Copy link
Collaborator

Committed 280003@main (50c1741): https://commits.webkit.org/280003@main

Reviewed commits have been landed. Closing PR #29810 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 50c1741 into WebKit:main Jun 14, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants