Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(279376@main): [WPE] Build broken with ENABLE_WEBDRIVER=OFF #29772

Merged
merged 1 commit into from
Jun 13, 2024
Merged

REGRESSION(279376@main): [WPE] Build broken with ENABLE_WEBDRIVER=OFF #29772

merged 1 commit into from
Jun 13, 2024
+40 −43

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Jun 12, 2024 •
edited by webkit-early-warning-system

03618f4

REGRESSION(279376@main): [WPE] Build broken with ENABLE_WEBDRIVER=OFF
https://bugs.webkit.org/show_bug.cgi?id=275423

Reviewed by Michael Catanzaro.

Move some parts of WebAutomationSession.cpp under their corresponding
guards to avoid trying to build them when ENABLE_WEBDRIVER is disabled.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
(WebKit::deviceScaleLocationInView): Guard with ENABLE(WEBDRIVER) to
avoid defined-but-unused warning when building with WebDriver disabled.
(WebKit::libWPEStateModifierForWPEButton): Guard with
ENABLE(WEBDRIVER_MOUSE_INTERACTIONS), as it's the case with its
declraration.
(WebKit::doMouseEvent): Move under a ENABLE(WEBDRIVER_MOUSE_INTERACTIONS)
guard to avoid defined-but-unused compiler warnings.
(WebKit::doMotionEvent): Ditto.
(WebKit::libWPEMouseButtonToWPEButton): Ditto.

Canonical link: https://commits.webkit.org/279973@main

cfb255d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@aperezdc aperezdc requested review from donny-dont, zdobersek and a team as code owners June 12, 2024 22:58
@aperezdc aperezdc self-assigned this Jun 12, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash cfb255d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@aperezdc aperezdc added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 12, 2024
@aperezdc aperezdc requested a review from lauromoura June 12, 2024 22:59
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2024
@aperezdc
REGRESSION(279376@main): [WPE] Build broken with ENABLE_WEBDRIVER=OFF
03618f4 
https://bugs.webkit.org/show_bug.cgi?id=275423

Reviewed by Michael Catanzaro.

Move some parts of WebAutomationSession.cpp under their corresponding
guards to avoid trying to build them when ENABLE_WEBDRIVER is disabled.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
(WebKit::deviceScaleLocationInView): Guard with ENABLE(WEBDRIVER) to
avoid defined-but-unused warning when building with WebDriver disabled.
(WebKit::libWPEStateModifierForWPEButton): Guard with
ENABLE(WEBDRIVER_MOUSE_INTERACTIONS), as it's the case with its
declraration.
(WebKit::doMouseEvent): Move under a ENABLE(WEBDRIVER_MOUSE_INTERACTIONS)
guard to avoid defined-but-unused compiler warnings.
(WebKit::doMotionEvent): Ditto.
(WebKit::libWPEMouseButtonToWPEButton): Ditto.

Canonical link: https://commits.webkit.org/279973@main
@webkit-commit-queue webkit-commit-queue force-pushed the aperezdc/wpe-fix-build-webdriver-off branch from cfb255d to 03618f4 Compare June 13, 2024 01:33
@webkit-commit-queue
Copy link
Collaborator

Committed 279973@main (03618f4): https://commits.webkit.org/279973@main

Reviewed commits have been landed. Closing PR #29772 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 03618f4 into WebKit:main Jun 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@donny-dont donny-dont Awaiting requested review from donny-dont donny-dont is a code owner

@zdobersek zdobersek Awaiting requested review from zdobersek zdobersek is a code owner

@lauromoura lauromoura Awaiting requested review from lauromoura

Assignees

@aperezdc aperezdc

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@aperezdc @webkit-early-warning-system @webkit-commit-queue @mcatanzaro