Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebXR] Copy rate map samples into IPC message #29738

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[WebXR] Copy rate map samples into IPC message #29738

merged 1 commit into from
Jun 13, 2024

Conversation

djg
Copy link
Contributor

@djg djg commented Jun 12, 2024 •
edited by webkit-early-warning-system

8ad29aa

[WebXR] Copy rate map samples into IPC message
https://bugs.webkit.org/show_bug.cgi?id=275389
rdar://129658002

Reviewed by Mike Wyrzykowski and Kimmo Kinnunen.

Intermittent corruption of WebXR rendering has been observed which is resulting
from a corruption of the first few horizontal samples for the rasterization rate
maps to support static foveation between creating the message payload and the
point at which the message is sent over IPC.

This change copies the rate map samples into the message, storing them in
Vectors.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/platform/xr/PlatformXR.h:
* Source/WebKit/Shared/XR/PlatformXR.serialization.in:

Canonical link: https://commits.webkit.org/279972@main

aa27eac

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@djg djg self-assigned this Jun 12, 2024
@djg djg added the WebXR For bugs in WebXR label Jun 12, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b42d1a8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@djg djg force-pushed the eng/WebXR-Copy-rate-map-samples-into-IPC-message branch from b42d1a8 to aa27eac Compare June 12, 2024 07:54
@djg djg changed the title [WebXR} Copy rate map samples into IPC message [WebXR] Copy rate map samples into IPC message Jun 12, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash aa27eac)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@djg djg added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2024
@djg
[WebXR] Copy rate map samples into IPC message
8ad29aa 
https://bugs.webkit.org/show_bug.cgi?id=275389
rdar://129658002

Reviewed by Mike Wyrzykowski and Kimmo Kinnunen.

Intermittent corruption of WebXR rendering has been observed which is resulting
from a corruption of the first few horizontal samples for the rasterization rate
maps to support static foveation between creating the message payload and the
point at which the message is sent over IPC.

This change copies the rate map samples into the message, storing them in
Vectors.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/platform/xr/PlatformXR.h:
* Source/WebKit/Shared/XR/PlatformXR.serialization.in:

Canonical link: https://commits.webkit.org/279972@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebXR-Copy-rate-map-samples-into-IPC-message branch from aa27eac to 8ad29aa Compare June 13, 2024 01:28
@webkit-commit-queue
Copy link
Collaborator

Committed 279972@main (8ad29aa): https://commits.webkit.org/279972@main

Reviewed commits have been landed. Closing PR #29738 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8ad29aa into WebKit:main Jun 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2024
@djg djg deleted the eng/WebXR-Copy-rate-map-samples-into-IPC-message branch June 13, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkinnunen-apple kkinnunen-apple kkinnunen-apple approved these changes

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

Assignees

@djg djg

Labels
WebXR For bugs in WebXR
Projects
None yet
Milestone
No milestone
5 participants
@djg @webkit-early-warning-system @webkit-commit-queue @kkinnunen-apple @mwyrzykowski