Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remove unused variable 'resizeControlRect' at RenderLayerScrollableArea::hitTestOverflowControls" #29697

Merged
merged 1 commit into from
Jun 11, 2024
Merged

"Remove unused variable 'resizeControlRect' at RenderLayerScrollableArea::hitTestOverflowControls" #29697

merged 1 commit into from
Jun 11, 2024

Conversation

vitorroriz
Copy link
Contributor

@vitorroriz vitorroriz commented Jun 11, 2024 •
edited by webkit-early-warning-system

aa90f79

"Remove unused variable 'resizeControlRect' at RenderLayerScrollableArea::hitTestOverflowControls"
https://bugs.webkit.org/show_bug.cgi?id=275342
rdar://129547434

Reviewed by Simon Fraser.

* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::hitTestOverflowControls):

Canonical link: https://commits.webkit.org/279897@main

f717dd3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz self-assigned this Jun 11, 2024
@vitorroriz vitorroriz added the Layout and Rendering For bugs with layout and rendering of Web pages. label Jun 11, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f717dd3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@vitorroriz vitorroriz requested a review from smfr June 11, 2024 02:57
@vitorroriz vitorroriz added the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2024
@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jun 11, 2024
@vitorroriz vitorroriz removed the merging-blocked Applied to prevent a change from being merged label Jun 11, 2024
@vitorroriz
Copy link
Contributor Author

Not related test failure

@vitorroriz vitorroriz added the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2024
@vitorroriz
"Remove unused variable 'resizeControlRect' at RenderLayerScrollableA…
aa90f79 
…rea::hitTestOverflowControls"

https://bugs.webkit.org/show_bug.cgi?id=275342
rdar://129547434

Reviewed by Simon Fraser.

* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::hitTestOverflowControls):

Canonical link: https://commits.webkit.org/279897@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-unused-variable-resizeControlRect-at-RenderLayerScrollableAreahitTestOverflowControls branch from f717dd3 to aa90f79 Compare June 11, 2024 05:45
@webkit-commit-queue
Copy link
Collaborator

Committed 279897@main (aa90f79): https://commits.webkit.org/279897@main

Reviewed commits have been landed. Closing PR #29697 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit aa90f79 into WebKit:main Jun 11, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@vitorroriz vitorroriz

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
4 participants
@vitorroriz @webkit-early-warning-system @webkit-commit-queue @smfr