258ed7a

[css-anchor-position-1] Add parsing support for `anchor()`
https://bugs.webkit.org/show_bug.cgi?id=275063
rdar://129168625

Reviewed by Antti Koivisto.

This patch adds initial parsing support for `anchor()` and introduces
a new CSSValue subclass named CSSAnchorValue. This class is also
implemented as a CSSPrimitiveValue. Note that the parsers for inset
properties (left, top, inset-block-end, etc.) have been modified to
accept `anchor()` as a value, whereas `anchor()` is not accepted as a
<length> in other properties by default.

This patch does not support parsing `anchor()` calls in other CSS math
functions (such as `calc()` and `min()`).

Previously WebKit ignored inset property declarations using `anchor()`.
Now, because these values are properly parsed, any inset properties
using `anchor()` are assigned a default fixed length of 0 during
style resolution. (This causes many spurious test rebaselines.)

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSAnchorValue.cpp: Added.
(WebCore::CSSAnchorValue::create):
(WebCore::CSSAnchorValue::collectComputedStyleDependencies const):
(WebCore::CSSAnchorValue::customCSSText const):
(WebCore::CSSAnchorValue::equals const):
* Source/WebCore/css/CSSAnchorValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::~CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::unitTypeString):
(WebCore::CSSPrimitiveValue::serializeInternal const):
(WebCore::CSSPrimitiveValue::equals const):
(WebCore::CSSPrimitiveValue::addDerivedHash const):
(WebCore::CSSPrimitiveValue::collectComputedStyleDependencies const):
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSUnits.cpp:
(WebCore::unitCategory):
(WebCore::operator<<):
* Source/WebCore/css/CSSUnits.h:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isAnchorValue const):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::hasDoubleValue):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.cpp:
(WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Primitives.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDashedIdent):
(WebCore::CSSPropertyParserHelpers::consumeAutoOrLengthOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeSide):
(WebCore::CSSPropertyParserHelpers::consumeInsetLogicalStartEnd):
(WebCore::CSSPropertyParserHelpers::consumeAnchor):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLength):

Canonical link: https://commits.webkit.org/279891@main

ee9c97a