Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visionOS] CRASH in PlaybackSessionManagerProxy::uncacheVideoReceiverEndpoint() #29603

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[visionOS] CRASH in PlaybackSessionManagerProxy::uncacheVideoReceiverEndpoint() #29603

merged 1 commit into from
Jun 11, 2024

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Jun 7, 2024 •
edited by webkit-early-warning-system

39a63aa

[visionOS] CRASH in PlaybackSessionManagerProxy::uncacheVideoReceiverEndpoint()
https://bugs.webkit.org/show_bug.cgi?id=275236
rdar://129208917

Reviewed by Andy Estes.

Proactively invalidate the PlaybackSessionModelContext, which as a side effect will call
uncacheVideoReceiverEndpoint(), rather than doing so in the middle of the destructor.

* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::~PlaybackSessionModelContext):
(WebKit::PlaybackSessionModelContext::setVideoReceiverEndpoint):
(WebKit::PlaybackSessionModelContext::invalidate):
(WebKit::PlaybackSessionManagerProxy::invalidate):

Canonical link: https://commits.webkit.org/279911@main

9e85f2e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble requested a review from cdumez as a code owner June 7, 2024 00:46
@jernoble jernoble self-assigned this Jun 7, 2024
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Jun 7, 2024
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for a23765f. Live statuses available at the PR page, #29603

1 similar comment
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for a23765f. Live statuses available at the PR page, #29603

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 7, 2024
@jernoble jernoble requested a review from a team June 7, 2024 15:53
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 7, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash a23765f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 7, 2024
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 10, 2024
@jernoble jernoble force-pushed the eng/visionOS-CRASH-in-PlaybackSessionManagerProxyuncacheVideoReceiverEndpoint branch from a23765f to 9e85f2e Compare June 10, 2024 23:16
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9e85f2e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2024
@jernoble
[visionOS] CRASH in PlaybackSessionManagerProxy::uncacheVideoReceiver…
39a63aa 
…Endpoint()

https://bugs.webkit.org/show_bug.cgi?id=275236
rdar://129208917

Reviewed by Andy Estes.

Proactively invalidate the PlaybackSessionModelContext, which as a side effect will call
uncacheVideoReceiverEndpoint(), rather than doing so in the middle of the destructor.

* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::~PlaybackSessionModelContext):
(WebKit::PlaybackSessionModelContext::setVideoReceiverEndpoint):
(WebKit::PlaybackSessionModelContext::invalidate):
(WebKit::PlaybackSessionManagerProxy::invalidate):

Canonical link: https://commits.webkit.org/279911@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/visionOS-CRASH-in-PlaybackSessionManagerProxyuncacheVideoReceiverEndpoint branch from 9e85f2e to 39a63aa Compare June 11, 2024 16:12
@webkit-commit-queue
Copy link
Collaborator

Committed 279911@main (39a63aa): https://commits.webkit.org/279911@main

Reviewed commits have been landed. Closing PR #29603 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 39a63aa into WebKit:main Jun 11, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aestes aestes aestes approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@jernoble jernoble

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@jernoble @webkit-early-warning-system @webkit-commit-queue @aestes @webkit-ews-buildbot