PCM: Change WebIDL attributes from all lowercase to camelcase to matc…

…h spec and align with Attribution Reporting API https://bugs.webkit.org/show_bug.cgi?id=230914 <rdar://problem/83639923> Reviewed by Brent Fulgham. This patch changes Private Click Measurement's WebIDL attributes from all lowercase to camelcase to match the spec and align with the Attribution Reporting API proposal. References - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor Source/WebCore: Existing tests updated. * html/HTMLAnchorElement.idl: LayoutTests: * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt: * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html: * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html: Canonical link: https://commits.webkit.org/242358@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Sep 30, 2021 · f4e94ae · f4e94ae
1 parent bb4e403
commit f4e94ae
Show file tree

Hide file tree

Showing 6 changed files with 51 additions and 11 deletions.
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,23 @@
+2021-09-30 John Wilander <[email protected]>
+
+ PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+ https://bugs.webkit.org/show_bug.cgi?id=230914
+ <rdar://problem/83639923>
+
+ Reviewed by Brent Fulgham.
+
+ This patch changes Private Click Measurement's WebIDL attributes from
+ all lowercase to camelcase to match the spec and align with the
+ Attribution Reporting API proposal.
+
+ References
+ - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+ - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
+
 2021-09-30 Ziran Sun <[email protected]>
 
  [css-grid] Transfer sizes from the aspect-ratio while resolving min-length for auto repetitions

diff --git a/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt b/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt
@@ -1,10 +1,10 @@
-Test for the new private click measurement attributes on anchor tags.
+Test for private click measurement attributes on anchor tags.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS anchorTag.attributionsourceid is 40
-PASS anchorTag.attributiondestination is "https://destination.example"
+PASS anchorTag.attributionSourceId is 40
+PASS anchorTag.attributionDestination is "https://destination.example"
 PASS successfullyParsed is true
 
 TEST COMPLETE

diff --git a/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html b/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html
@@ -7,11 +7,11 @@
 <body>
 <a id="testTag" href="http://localhost:8000" attributionsourceid=40 attributiondestination="https://destination.example"></a>
 <script>
- description("Test for the new private click measurement attributes on anchor tags.");
+ description("Test for private click measurement attributes on anchor tags.");
 
  const anchorTag = document.getElementById("testTag");
- shouldBeEqualToNumber("anchorTag.attributionsourceid", 40);
- shouldBeEqualToString("anchorTag.attributiondestination", "https://destination.example");
+ shouldBeEqualToNumber("anchorTag.attributionSourceId", 40);
+ shouldBeEqualToString("anchorTag.attributionDestination", "https://destination.example");
 </script>
 </body>
 </html>
diff --git a/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html b/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html
@@ -25,9 +25,9 @@
  anchorElement.id = elementID;
  anchorElement.classList.add("wide-link");
  if (sourceID !== null)
- anchorElement.attributionsourceid = sourceID;
+ anchorElement.attributionSourceId = sourceID;
  if (destination !== null)
- anchorElement.attributiondestination = destination;
+ anchorElement.attributionDestination = destination;
  anchorElement.href = "#";
  anchorElement.innerText = "Link" + currentTest;
  return anchorElement;

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,23 @@
+2021-09-30 John Wilander <[email protected]>
+
+ PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+ https://bugs.webkit.org/show_bug.cgi?id=230914
+ <rdar://problem/83639923>
+
+ Reviewed by Brent Fulgham.
+
+ This patch changes Private Click Measurement's WebIDL attributes from
+ all lowercase to camelcase to match the spec and align with the
+ Attribution Reporting API proposal.
+
+ References
+ - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+ - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+ Existing tests updated.
+
+ * html/HTMLAnchorElement.idl:
+
 2021-09-30 Rob Buis <[email protected]>
 
  Move canCompositeClipPath to RenderLayer

diff --git a/Source/WebCore/html/HTMLAnchorElement.idl b/Source/WebCore/html/HTMLAnchorElement.idl
@@ -21,9 +21,9 @@
 [
  Exposed=Window
 ] interface HTMLAnchorElement : HTMLElement {
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionsourceid;
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributiondestination;
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionsourcenonce;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionSourceId;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributionDestination;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionSourceNonce;
  [CEReactions=NotNeeded, Reflect] attribute DOMString charset;
  [CEReactions=NotNeeded, Reflect] attribute DOMString coords;
  [CEReactions=NotNeeded, Conditional=DOWNLOAD_ATTRIBUTE, EnabledBySetting=DownloadAttribute, Reflect] attribute DOMString download;