Add mechanism to specify debug mode for auctionReportBuyers reporting #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new parameter to the auctionConfig to allow the debug mode to be enabled for Private Aggregation reports sent via auctionReportBuyers
|
@qingxinwu could you PTAL at this too? Thanks! |
qingxinwu
reviewed
Jan 22, 2024
FLEDGE_extended_PA_reporting.md
Outdated
| } | ||
|
|
||
| // Additional parameter for configuring the debug mode | ||
| 'auctionReportBuyerDebugModeConfigs': [ |
There was a problem hiding this comment.
maybe add a sentence below to describe the auctionReportBuyerDebugModeConfigs field with more details, like its debugKey is optional, enabled is false if not provided, etc,.
There was a problem hiding this comment.
yep, makes sense. added some more details
qingxinwu
approved these changes
Jan 22, 2024
|
@qingxinwu sorry for the churn, but I just realized that having a different config for each buyer doesn't really make sense. All these reports are going to the same seller, so we probably only want one config. PTAL and let me know if you think that makes sense. (Side note: I'll work to update the cl now.) |
I think it makes sense. There's no per-buyer related information to be included in the report when debug mode is enabled, right? So that there's no need to control the config at per-buyer level? |
|
Yeah, that was my thinking too. Thanks for the re-review! |
|
may want to reference to #709 in the PR's description. |
|
Done! |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 23, 2024
Adds support for enabling the Private Aggregation debug mode for this type of reporting. This is enabled through a new, optional field on the auctionConfig (defaulting to debug mode disabled). See the proposed explainer update here: WICG/turtledove#997 This enables the new feature by default, but this feature will be disabled before reaching Stable if it not yet approved in an I2S. Low-Coverage-Reason: Simple mojom traits accessors Bug: 1513013 Change-Id: I4f55b1f6d0563ab39e795a136a8b40e931e87313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5134306 Commit-Queue: Alex Turner <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Qingxin Wu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1251011}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 24, 2024
This reverts commit 60e5bac. Reason for revert: Causing try job failures blocking CQ: https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1654390/blamelist See bug. Bug: 1521132 Original change's description: > Support debug mode in auctionReportBuyers reporting > > Adds support for enabling the Private Aggregation debug mode for this > type of reporting. This is enabled through a new, optional field on the > auctionConfig (defaulting to debug mode disabled). > > See the proposed explainer update here: > WICG/turtledove#997 > > This enables the new feature by default, but this feature will be > disabled before reaching Stable if it not yet approved in an I2S. > > Low-Coverage-Reason: Simple mojom traits accessors > Bug: 1513013 > Change-Id: I4f55b1f6d0563ab39e795a136a8b40e931e87313 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5134306 > Commit-Queue: Alex Turner <[email protected]> > Reviewed-by: Dominic Farolino <[email protected]> > Reviewed-by: Qingxin Wu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1251011} Bug: 1513013 Change-Id: I9c4c4a683b82bd1d2a5597e3a0881e9e095f8f19 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232840 Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Alan Cutter <[email protected]> Commit-Queue: Alan Cutter <[email protected]> Cr-Commit-Position: refs/heads/main@{#1251216}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 24, 2024
This is a reland of commit 60e5bac Original change was speculatively reverted due to tryjob failures, but another cl was the actual culprit. Original change's description: > Support debug mode in auctionReportBuyers reporting > > Adds support for enabling the Private Aggregation debug mode for this > type of reporting. This is enabled through a new, optional field on the > auctionConfig (defaulting to debug mode disabled). > > See the proposed explainer update here: > WICG/turtledove#997 > > This enables the new feature by default, but this feature will be > disabled before reaching Stable if it not yet approved in an I2S. > > Low-Coverage-Reason: Simple mojom traits accessors > Bug: 1513013 > Change-Id: I4f55b1f6d0563ab39e795a136a8b40e931e87313 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5134306 > Commit-Queue: Alex Turner <[email protected]> > Reviewed-by: Dominic Farolino <[email protected]> > Reviewed-by: Qingxin Wu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1251011} Bug: 1513013, 1521132 Change-Id: Id52213226117cb4179a8f38c4f4d05200d0bef57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5231585 Reviewed-by: Qingxin Wu <[email protected]> Auto-Submit: Alex Turner <[email protected]> Commit-Queue: Alex Turner <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1251684}
|
When do you expect the relanded CL to hit Canary? |
|
The relanded cl should now be available in the latest Canary (123.0.6264.0) |
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to the auctionConfig to allow the debug mode to be enabled for Private Aggregation reports sent via auctionReportBuyers. See #709 for additional context.