Rename Private Aggregation functions #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes reportContributionForEvent() to contributeToHistogramOnEvent() to be more accurate and consistent with other Private Aggregation functions. Functionality is otherwise unchanged. See patcg-individual-drafts/private-aggregation-api#48
|
@JensenPaul could you PTAL? Thanks! |
|
Looks like the corresponding impl change lands in M115 which goes to stable July 18th. When do you want me to merge this PR? |
|
I think it's good to merge now -- we have documentation that explains the exact timing of the change on developer.chrome.com |
github-actions bot
added a commit
that referenced
this pull request
Jun 22, 2023
SHA: 27c280d Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Jun 22, 2023
SHA: 27c280d Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes sendHistogramReport() to contributeToHistogram() and reportContributionForEvent() to contributeToHistogramOnEvent() to be more accurate and consistent. Functionality is otherwise unchanged.
See patcg-individual-drafts/private-aggregation-api#48