Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes to make FLEDGE understand ad sizes #417

Merged
merged 63 commits into from
Oct 31, 2023
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
1a2368f
Update generateBid()
gtanzer Dec 12, 2022
ff42d5b
Most of joinAdInterestGroup changes
gtanzer Dec 13, 2022
d63d8e1
Expand description of joinAdInterestGroup fields
gtanzer Dec 13, 2022
8851afc
Add runAdAuction requestedSize field
gtanzer Dec 13, 2022
d662fb7
Update generateBid description
gtanzer Dec 13, 2022
038f2ca
Update FLEDGE.md
gtanzer Dec 13, 2022
7791d78
Update FLEDGE.md
gtanzer Dec 13, 2022
397e544
Update k-anon check
gtanzer Dec 13, 2022
19c08f5
Update FLEDGE.md
gtanzer Dec 13, 2022
bbc82b5
Describe size macros
gtanzer Dec 13, 2022
0251bbc
Update Release_Notes.md
gtanzer Dec 19, 2022
3ef5be6
Fix typo
gtanzer Jan 5, 2023
fc9653f
Describe how size returned from generateBid is used
gtanzer Jan 5, 2023
01ef829
Remove mention of filtering
gtanzer Jan 5, 2023
a0a310d
Describe purpose of sizes in interest group declaration
gtanzer Jan 5, 2023
1ddddee
Update Release_Notes.md
gtanzer Feb 8, 2023
d642777
Update Release_Notes.md
gtanzer Mar 30, 2023
f25854c
Update Release_Notes.md
gtanzer Mar 30, 2023
d119ceb
Merge branch 'main' into patch-3
JensenPaul Apr 7, 2023
5380368
Accept `sizeGroups` suggestion
gtanzer Apr 10, 2023
d102fbc
Accept suggestion
gtanzer Apr 11, 2023
47d50e6
Accept suggestion to use group1 and group2 in ad size example
gtanzer Apr 11, 2023
568873a
Accept suggestion to explicitly call out the "size3" example size->si…
gtanzer Apr 11, 2023
0a3db48
Accept suggestion to call out AD_WIDTH and AD_HEIGHT explicitly in "s…
gtanzer Apr 11, 2023
adf4cbc
Accept suggestion to turn "url+size" into "URL and size"
gtanzer Apr 11, 2023
cb668e8
Accept suggestion to rephrase interest group size declaration descrip…
gtanzer Apr 11, 2023
733a821
Mention optionality of interest group size fields
gtanzer Apr 24, 2023
3ec71ac
Remark that sizes are also optional in generateBid
gtanzer Apr 24, 2023
cfbcb70
Add more (optionally)s
gtanzer Apr 24, 2023
7c6aa0e
Update Release_Notes.md
gtanzer Apr 24, 2023
85c2f60
Add more optionality
gtanzer Apr 27, 2023
1e07855
Add more optionality
gtanzer Apr 27, 2023
c1e00cf
Update FLEDGE.md
gtanzer May 5, 2023
2d44dd9
Update FLEDGE.md
gtanzer May 5, 2023
7625240
Update FLEDGE.md
gtanzer May 5, 2023
9ecc5f6
Update FLEDGE.md
gtanzer May 5, 2023
4efd2e8
Update FLEDGE.md
gtanzer May 5, 2023
064841f
Update FLEDGE.md
gtanzer May 5, 2023
8199508
Update FLEDGE.md
gtanzer May 8, 2023
81a8bf9
Update FLEDGE.md
gtanzer May 8, 2023
7b856f7
Update FLEDGE.md
gtanzer May 8, 2023
0cc20cb
Update Release_Notes.md
gtanzer May 8, 2023
21795b9
Update requestedSize description
gtanzer May 8, 2023
ed3b830
Update browser signals
gtanzer May 8, 2023
cd73790
Update FLEDGE.md
gtanzer May 8, 2023
06ace19
Change M115 to M116 for browser signals additions
gtanzer May 26, 2023
ca80dd8
Fix "bid" -> "auction config"
gtanzer Jun 9, 2023
910a9f2
Remove renderSize from reportResult signals
gtanzer Jun 12, 2023
3170266
Merge branch 'main' into patch-3
gtanzer Aug 4, 2023
b65b04a
Update FLEDGE.md
gtanzer Aug 4, 2023
4d4364b
Update FLEDGE.md
gtanzer Aug 4, 2023
6e6ec85
Update FLEDGE.md
gtanzer Aug 8, 2023
975e965
Fix rebase issue
gtanzer Aug 8, 2023
c3fad7a
Add extra macro format
gtanzer Sep 1, 2023
cce7780
Fix {size: ...}
gtanzer Sep 1, 2023
3e34e0d
Merge branch 'main' into patch-3
gtanzer Oct 16, 2023
a3662d5
Add explicit transition period
gtanzer Oct 26, 2023
d69f233
Add explicit transition period
gtanzer Oct 26, 2023
2d3f228
Add explicit transition period
gtanzer Oct 26, 2023
a57adbe
Update FLEDGE.md
JensenPaul Oct 30, 2023
7148d74
Fix link and perens.
JensenPaul Oct 30, 2023
f8cd3f6
Update FLEDGE.md
JensenPaul Oct 31, 2023
50893b4
add missing space
JensenPaul Oct 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FLEDGE.md
  • Loading branch information
gtanzer committed Dec 13, 2022
commit 19c08f5e79eb045cbfbc19074ff1020d802277cc
2 changes: 1 addition & 1 deletion FLEDGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ The arguments to this function are:
* sellerSignals: Like auctionConfig.sellerSignals, but passed via the [directFromSellerSignals](#25-additional-trusted-signals-directfromsellersignals) mechanism. These are the signals whose subresource URL ends in `?sellerSignals`.
* auctionSignals: Like auctionConfig.auctionSignals, but passed via the [directFromSellerSignals](#25-additional-trusted-signals-directfromsellersignals) mechanism. These are the signals whose subresource URL ends in `?auctionSignals`.

The `browserSignals` argument must be handled carefully to avoid tracking. It certainly cannot include anything like the full list of interest groups, which would be too identifiable as a tracking signal. The `renderUrl` can be included since it has already passed a k-anonymity check. The browser may limit the precision of the bid and desirability values to avoid these numbers exfiltrating information from the interest group's `userBiddingSignals`. On the upside, this set of signals can be expanded to include useful additional summary data about the wider range of bids that participated in the auction, e.g. the second-highest bid or the number of bids. Additionally, the `dataVersion` will only be present if the `Data-Version` header was provided in the response headers from the Trusted Scoring server.
The `browserSignals` argument must be handled carefully to avoid tracking. It certainly cannot include anything like the full list of interest groups, which would be too identifiable as a tracking signal. The `renderUrl` and `renderSize` can be included since they hvae already passed a k-anonymity check. The browser may limit the precision of the bid and desirability values to avoid these numbers exfiltrating information from the interest group's `userBiddingSignals`. On the upside, this set of signals can be expanded to include useful additional summary data about the wider range of bids that participated in the auction, e.g. the second-highest bid or the number of bids. Additionally, the `dataVersion` will only be present if the `Data-Version` header was provided in the response headers from the Trusted Scoring server.

The `reportResult()` function's reporting happens by directly calling network APIs in the short-term, but will eventually go through the Private Aggregation API once it has been developed. The output of this function is not used for reporting, but rather as an input to the buyer's reporting function.

Expand Down