fix some inconsistencies in extended PA reporting explainer #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qingxinwu
commented
Nov 30, 2022
- The API is reportContributionForEvent, not reportContributionsForEvent used in examples.
- The parameters to the API are event type and contributions as two separate parameters, not in one single object as two fields.
- bucket should be bigint, not number literals some examples had.
1. The API is reportContributionForEvent, not reportContributionsForEvent used in examples. 2. The parameters to the API are event type and contributions as two separate parameters, not in one single object as two fields. 3. bucket should be bigint, not number literals some examples had.
|
LGTM |
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2022
SHA: 6e82f3a Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.