Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended PA Reporting: Improve code block styling #1107

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

dmcardle
Copy link
Contributor

This commit annotates sufficiently JavaScript-like code blocks to enable syntax highlighting.

It also replaces non-ascii quotation marks and ellipses with ASCII equivalents.

@dmcardle dmcardle force-pushed the dmcardle-ascii-chars branch 2 times, most recently from 58cdd69 to 3801c1a Compare March 29, 2024 21:01
This commit annotates sufficiently JavaScript-like code blocks to enable
syntax highlighting.

It replaces non-ASCII quotation marks and ellipses with ASCII
equivalents.

It also replaces backticks with single quotes inside of the JavaScript
code blocks, since there were no template literals inside the
backtick-delimited strings.
@dmcardle
Copy link
Contributor Author

dmcardle commented Apr 1, 2024

@qingxinwu PTAL!

Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JensenPaul JensenPaul merged commit 65e0219 into WICG:main Apr 2, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Apr 2, 2024
SHA: 65e0219
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants