Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify top-level navigation with new _unfencedTop keyword #20

Open
gtanzer opened this issue Mar 30, 2022 · 0 comments
Open

Specify top-level navigation with new _unfencedTop keyword #20

gtanzer opened this issue Mar 30, 2022 · 0 comments
Labels
specification Additions to specifications

Comments

@gtanzer
Copy link
Collaborator

gtanzer commented Mar 30, 2022

Specify top-level navigation inside opaque-ads fenced frames using the new reserved target "_unfencedTop", which acts like "_top" but ignores fence boundaries.

Decision point: should _unfencedTop act like a normal target name outside opaque-ads fenced frames, or be prohibited?
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 31, 2022
Fenced Frames: Enable _unfencedTop only in ShadowDOM opaque-ads mode
dba5954 
This CL disables _unfencedTop in MPArch and in modes other than
opaque-ads. This unblocks MPArch OT, because _unfencedTop will work as a
normal target name and open an auxiliary browsing context. (So the same
ad code will work in both ShadowDOM and MPArch, albeit with slightly
different (but both acceptable) behaviors.)

The correct implementation of _unfencedTop in MPArch will come later,
hopefully before OT.

Fenced frames spec issue: WICG/fenced-frame#20

Bug: 1123606
Change-Id: I1c2414b3bac73f5ed94a6b3c3b0668229c70307d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551022
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Garrett Tanzer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#987407}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
Fenced Frames: Enable _unfencedTop only in ShadowDOM opaque-ads mode
691cd76 
This CL disables _unfencedTop in MPArch and in modes other than
opaque-ads. This unblocks MPArch OT, because _unfencedTop will work as a
normal target name and open an auxiliary browsing context. (So the same
ad code will work in both ShadowDOM and MPArch, albeit with slightly
different (but both acceptable) behaviors.)

The correct implementation of _unfencedTop in MPArch will come later,
hopefully before OT.

Fenced frames spec issue: WICG/fenced-frame#20

Bug: 1123606
Change-Id: I1c2414b3bac73f5ed94a6b3c3b0668229c70307d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551022
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Garrett Tanzer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#987407}
NOKEYCHECK=True
GitOrigin-RevId: dba5954bdbed4bd471a2a1df1ed4fea7a8b442d7
@domfarolino domfarolino added the specification Additions to specifications label Jun 3, 2023
@domfarolino domfarolino changed the title [Spec] Top-level navigation with _unfencedTop Specify top-level navigation with new _unfencedTop keyword Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
specification Additions to specifications
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domfarolino @gtanzer