Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregatable deduplication key field to trigger registration #527

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

linnan-github
Copy link
Collaborator

Copy link
Collaborator

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linnan-github linnan-github merged commit cacb444 into main Sep 26, 2022
aarongable pushed a commit to chromium/chromium that referenced this pull request Sep 29, 2022
WICG/attribution-reporting-api#527

This CL adds aggregatable deduplication key to trigger registration to
allow deduplication mechanism for aggregatable reports. The
deduplication keys are separate for event-level and aggregatable
reports.

Bug: 1368147
Change-Id: Ic6871436e2b3a95e81d8de29f3ad58c7021d7482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918652
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1052902}
@linnan-github linnan-github deleted the aggregatableDedupKey branch September 29, 2022 15:36
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
WICG/attribution-reporting-api#527

This CL adds aggregatable deduplication key to trigger registration to
allow deduplication mechanism for aggregatable reports. The
deduplication keys are separate for event-level and aggregatable
reports.

Bug: 1368147
Change-Id: Ic6871436e2b3a95e81d8de29f3ad58c7021d7482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918652
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1052902}
NOKEYCHECK=True
GitOrigin-RevId: ac45a94a24a387f4d9ffff519c3d0dfab2300486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Aggregate API] Tracking multiple trigger types
2 participants